v2-core icon indicating copy to clipboard operation
v2-core copied to clipboard

Published 20 hours ago • verified publisher icon sablier-labs

Refactor all tests to use Bulloak

Open PaulRBerg opened this issue 1 year ago • 3 comments

See:

  • https://github.com/alexfertel/bulloak
  • https://prberg.com/presentations/solidity-summit-2023

PaulRBerg avatar Jan 23 '24 11:01 PaulRBerg

I would mark this as priority 3

andreivladbrg avatar Jan 23 '24 11:01 andreivladbrg

Can we please switch to Bulloak in the next release, or at least do it in open-ended?

Reviewing PRs that modify BTs without Bulloak is a pain

PaulRBerg avatar Apr 05 '24 14:04 PaulRBerg

Yeah lets do it in next release as well as use it in the first release of open-ended.

smol-ninja avatar Apr 05 '24 14:04 smol-ninja

I am thinking of working on it since its been pending for a very long time and as we have seen in Flow, its useful too. Any objections since it could be a huge refactor?

smol-ninja avatar Aug 16 '24 12:08 smol-ninja

No objections. Just excitement!

PaulRBerg avatar Aug 16 '24 13:08 PaulRBerg

I have finished this. There are two PRs:

  1. https://github.com/sablier-labs/v2-core/pull/1022 for core
  2. https://github.com/sablier-labs/v2-core/pull/1025 for periphery

smol-ninja avatar Aug 26 '24 21:08 smol-ninja