v2-core icon indicating copy to clipboard operation
v2-core copied to clipboard

Create a Sablier-powered ERC-20 contract

Open PaulRBerg opened this issue 1 year ago • 1 comments

As discussed in https://github.com/sablier-labs/company-discussions/discussions/62#discussioncomment-10509265.

@smol-ninja's idea:

function _mintwithVesting(address account, uint256 value, params) internal {
    _mint(address(this), value);
    _approve(LOCKUP_LINEAR, value);
    // few parameters will be hard coded
    LOCKUP_LINEAR.createWithDurations(params);
}

PaulRBerg avatar Sep 02 '24 14:09 PaulRBerg

Once this is implemented, an adjacent task would be to attempt to get this ERC-20 template integrated in OpenZeppelin.

PaulRBerg avatar Sep 10 '24 12:09 PaulRBerg

Just checking we're still on track to include this in Lockup v2.0.0?

It's an important feature.

PaulRBerg avatar Oct 22 '24 12:10 PaulRBerg

Yes.

smol-ninja avatar Oct 22 '24 12:10 smol-ninja

Unfortunately, we won't have time to include this in v2.0.0 but maybe we can discuss it during the weekend in-person!

PaulRBerg avatar Nov 20 '24 18:11 PaulRBerg

Agree, no time for this

andreivladbrg avatar Nov 21 '24 05:11 andreivladbrg

Can we please hold onto this until we freeze the code? If I can't get it delivered by next Friday, we can omit it from v2.0.0.

smol-ninja avatar Nov 21 '24 11:11 smol-ninja

Yeah, sure. Let's discuss this during the weekend.

PaulRBerg avatar Nov 21 '24 15:11 PaulRBerg

Should I close this issue since we have an integration with CreateMyToken which is doing fantastic already?

smol-ninja avatar Feb 18 '25 10:02 smol-ninja

Yes, closing. Overkill to build our own

PaulRBerg avatar Feb 18 '25 15:02 PaulRBerg