Steven Perron

Looks like a duplicate of #5191

The aggressive dead code elimination pass should remove unused input. Can you provide a sample that I can double check?

I finally got around to looking at this. I see why DCE is not removing. We generally think of our optimizations working on single shader modules, because that use to...

``` RWStructuredBuffer localSBuffer = MyRWSBuffer[index]; localSBuffer.IncrementCounter(); ``` For cases like this, we should be able to issue an error during validation after legalization. We could add something to the validator...

> As for issue 2, I'll create a tracking issue to follow up. We should discuss this. We should not give a partially working feature until we have a design...

> (I mixed up issue 1 and 2 in my comment, fixed it) Cool, what is the error message?

@ShchchowAMD Do you have any idea how this is suppose to work?

I checked how the code is generated in glsl. The type for `fp_h[2]` is correct. The problem is in these lines: https://github.com/microsoft/DirectXShaderCompiler/blob/c997ea02605d2bc30176cfab14fa205ece2f5af9/tools/clang/lib/SPIRV/SpirvEmitter.cpp#L12151-L12157 The code assumes that is can add the...

I cannot reproduce the problem (https://godbolt.org/z/G3YnYddza). Can you please provide a compiler explorer link that demonstrates the problem?

I don't want to double down on the vk::combinedImageSampler attribute. After updating [inline spir-v](https://github.com/microsoft/hlsl-specs/pull/59), I'll see how we can handle this. As I work through the inline spr-v, I'll make...