vim-devicons icon indicating copy to clipboard operation
vim-devicons copied to clipboard

icons in NERDtree can be only shown half.

Open d0u9 opened this issue 9 years ago • 74 comments
trafficstars

A picture is worth a thousand words:

https://github.com/d0u9/test_repository/blob/master/pics/20151219-0.png?raw=true

There are dots shield half part of each icon in NERDtree.

Also, the space between icons and characters seems to wide...

PS: I use neovim and iTerm2 in OSX 10.11.2

d0u9 avatar Dec 19 '15 04:12 d0u9

For the dots try:

autocmd FileType nerdtree setlocal nolist

For spacing you can adjust with:

let g:WebDevIconsNerdTreeAfterGlyphPadding = '  '

ryanoasis avatar Dec 19 '15 04:12 ryanoasis

@ryanoasis Works! Thank you!

d0u9 avatar Dec 19 '15 04:12 d0u9

Hey no problem. Maybe I should consider setting this in the plugin by default

ryanoasis avatar Dec 19 '15 05:12 ryanoasis

Hi ryanoasis , I'm in trouble with configuration. Alt text

Version: Alt text It seems to occupy only one character bit.

Regards, PengJun

code-geeker avatar Apr 07 '16 09:04 code-geeker

I will try to test your vimrc, I think I found it on GitHub but could you post a link to the latest one?

In the meantime, are you using latest version of NerdTree and devicons?

Can you tell me which font you are using?

Is this macvim (gui) or vim on terminal?

ryanoasis avatar Apr 07 '16 15:04 ryanoasis

Hi ryanoasis, Thanks for your reply I just pushed the latest .vimrc file

Yes,they are both latest version.

This is the font: alt test

It is macvim(gui)

I suspect that the differing versions of macvim cause it. It works well on version 7.4-77 but doesn't work on 7.4-101 (https://github.com/macvim-dev/macvim/releases/tag/snapshot-101)

alt test

Regards, PengJun

code-geeker avatar Apr 07 '16 15:04 code-geeker

BTW, It works well on vim on termina Alt text

code-geeker avatar Apr 07 '16 15:04 code-geeker

@code-geeker Sorry for the delayed response. I am looking into this issue.

BTW for the terminal vim you showed can you give the output of :version there as well?

ryanoasis avatar May 13 '16 11:05 ryanoasis

@ryanoasis Thanks for your response. Alt text

code-geeker avatar May 13 '16 11:05 code-geeker

It goes like this in the MacVim. img

code-geeker avatar May 13 '16 11:05 code-geeker

Thanks. I will try to do some more digging

ryanoasis avatar May 13 '16 22:05 ryanoasis

same issue as @code-geeker

MacVim snapshot-104

set guifont=Meslo\ LG\ M\ Regular\ for\ Powerline\ Nerd\ Font\ Complete:h12

works well in terminal, even in neovim

lisposter avatar Jun 05 '16 07:06 lisposter

Sorry I still haven't had a chance to look into this, however @xusiyuan841028 has shared some info in the Gitter Chat that might be of some help to some of you. ¯(ツ)

https://github.com/macvim-dev/macvim/blob/0e954ac375d78d86cfd41377440c7f5977ae8924/src/screen.c#L8068-L8070

Some other references from searching (unsure if completely related):

https://github.com/macvim-dev/macvim/issues/267

https://github.com/vim/vim/issues/732

https://github.com/rogual/neovim-dot-app/issues/240

ryanoasis avatar Jun 08 '16 01:06 ryanoasis

Hey guys,

I'm using last macvim version (in homebrew) and last version for devicons and I have the same issue here: screen shot 2016-06-13 at 2 10 42 pm

An yes, I tried this code, but no success.

autocmd FileType nerdtree setlocal nolist
let g:WebDevIconsNerdTreeAfterGlyphPadding = '  '

The half icons bug happens with tabs also screen shot 2016-06-13 at 2 14 55 pm

lerrua avatar Jun 13 '16 17:06 lerrua

So, this can fix the issue set ambiwidth=double BUT breaks airline status line. Damm...

lerrua avatar Jun 13 '16 17:06 lerrua

The original issue from @d0u9 was actually a different problem (#84, #110) but we seem to now be using this issue in regards to a new (harder?) problem :stuck_out_tongue: ... so I am going to re-open this so there is less confusion and it's easier to find

@lerrua Hey yep sorry, still a serious issue.

Just wondering if anyone has been able to try @xusiyuan841028 suggested fix?

The cause of issue is that: https://github.com/macvim-dev/macvim/blob/0e954ac375d78d86cfd41377440c7f5977ae8924/src/screen.c#L8068-L8070

ryanoasis avatar Jun 13 '16 18:06 ryanoasis

@ryanoasis

My fix https://github.com/xusiyuan841028/macvim/commit/27bcfd27d6c3500b6ca27c7387a19b5a8306df17

You can install my edge version by:

brew install --HEAD xusiyuan841028/macvim/macvim

xusiyuan841028 avatar Jun 14 '16 02:06 xusiyuan841028

@xusiyuan841028 Thanks I just have not been able to test it out (I don't have access to a mac at the moment).

I was hoping someone else could verify/try the suggested fix

ryanoasis avatar Jun 14 '16 13:06 ryanoasis

Seems like possibly due to change https://github.com/vim/vim/commit/cb0700844c1274fe8bc0ceaffaee0ad21c406f30 ?

I really need to test on an updated version of vim. Will try this weekend

ryanoasis avatar Jun 14 '16 14:06 ryanoasis

@xusiyuan841028 I've tried your patched version, but still have half icons bug. What I did:

brew unlink macvim
brew install --HEAD xusiyuan841028/macvim/macvim
brew link --overwrite macvim

Is there anything else needed here?

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled May 14 2016 22:15:27) MacOS X (unix) version Included patches: 1-1816 Compiled by Homebrew

screen shot 2016-06-25 at 6 02 38 pm

valerybugakov avatar Jun 25 '16 13:06 valerybugakov

@valerybugakov Thanks for trying! I am not really sure if anything else is needed :worried:

ryanoasis avatar Jun 26 '16 21:06 ryanoasis

@ryanoasis oh, if there will be something I can do to help with this issue - tell me 😊 Awesome plugin and would be awesome to have it working properly on macvim!

valerybugakov avatar Jun 27 '16 05:06 valerybugakov

@valerybugakov I have tested the fixed macvim in another macbook, and it is fine. The version info is as following:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun 23 2016 09:53:11)
MacOS X (unix) version
Included patches: 1-1952

I find the message Compiled by Homebrew, so I don't think you really use my patched macvim. I suggest you uninstall macvim, and re-install my patched version.

brew uninstall macvim
brew cleanup
brew install --force xusiyuan841028/macvim/macvim --HEAD

xusiyuan841028 avatar Jun 28 '16 09:06 xusiyuan841028

@xusiyuan841028 thanks for the info, will try again in an hour 👍

valerybugakov avatar Jun 28 '16 09:06 valerybugakov

@valerybugakov please pay attention to compiled Jun 23 2016 09:53:11, I think the date should be the moment you install patched macvim. I will keep update my patched version until official version fixes the double-width char display issue. Everyone can use command brew uninstall macvim && brew install --force xusiyuan841028/macvim/macvim --HEAD to install the updated version.

xusiyuan841028 avatar Jun 28 '16 09:06 xusiyuan841028

@xusiyuan841028 should my Included patches match yours?

$ mvim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun 28 2016 19:00:38)
MacOS X (unix) version
Included patches: 1-1965

I still have the same result 😥 After installation I got a warning from brew that macvim wasn't linked properly and I did brew link --overwrite macvim. Is this ok or it can be a source of an issue?

valerybugakov avatar Jun 28 '16 15:06 valerybugakov

@xusiyuan841028 Is there something specific that will identify your build for 100%? (that I've installed it correctly and test plugin with it)

valerybugakov avatar Jun 28 '16 15:06 valerybugakov

@xusiyuan841028 also a strange thing, after that ctrlp stopped working for vim and macvim

valerybugakov avatar Jun 29 '16 16:06 valerybugakov

@valerybugakov Could you give me your email? I wanna your compiled MacVim and send mine to you, in order to check whether the patched version is available. Or you can contact with me via my public email.

xusiyuan841028 avatar Jun 29 '16 16:06 xusiyuan841028

@xusiyuan841028 sent you an email ([email protected])

valerybugakov avatar Jun 29 '16 17:06 valerybugakov