ProcessHannaCode icon indicating copy to clipboard operation
ProcessHannaCode copied to clipboard

Support for recursive Hanna code tags added and support for Hanna Code names with a dot and attributes added.

Open hwmaier opened this issue 10 years ago • 7 comments
trafficstars

Added support for Hanna Code names with a dot. Example: [[admin.email reaptcha="true"]]

Previously the Hanna Code parser did not recognise dotted names when attributes where passed as well.

Refer to https://processwire.com/talk/topic/3745-hanna-code/page-11#entry81765

hwmaier avatar Dec 19 '14 03:12 hwmaier

Support for recursive (= reentrant) Hanna Code tags added as well. Hanna Code now can render partial which again contain Hanna Code tags.

hwmaier avatar Jan 22 '15 11:01 hwmaier

Any idea when the recursive tag commit will be merged and made available as an update?

PeterKnightDigital avatar Mar 02 '15 14:03 PeterKnightDigital

No idea if this fix is even under the radar. There have been a few posts regards issues relating to recursion in the Hanna Code forums, so I believe it would be beneficial to the community to fix this obscure issue.

The fix has also been confirmed to work by other, refer to this post: https://processwire.com/talk/topic/3745-hanna-code/page-12#entry89134

hwmaier avatar Mar 02 '15 23:03 hwmaier

Thx for this addition. It also fixes my rendering issues with nested hanna code textformatters. Will this fix be comitted so that it shows up here?: http://modules.processwire.com/modules/process-hanna-code/ Would be great...

gingebaker avatar Nov 12 '15 15:11 gingebaker

Sorry for the repost. Is recursive HC now possible and committed in a recent or upcoming release?

PeterKnightDigital avatar Nov 12 '15 17:11 PeterKnightDigital

I think its Ryan's call to adopt the PR or not. At least the commit https://github.com/hwmaier/ProcessHannaCode/commit/da0cc66fb4f54b684e7be7ed1ee53fca95420e38 with the nested support should be added if the other change of the PR (hanna code names with dots) is not welcome.

I probably made the mistake to combine two changed into one PR.

hwmaier avatar Nov 13 '15 00:11 hwmaier

any updates on this pull request? i would really appreciate if at least the recursive HC would be merged

14pixels avatar Apr 11 '16 11:04 14pixels