returnn icon indicating copy to clipboard operation
returnn copied to clipboard

`OggZipDataset`: normalize // to / when reading files from archive

Open NeoLegends opened this issue 1 year ago • 3 comments

The dataset implementation joins some (potentially empty) paths, sometimes leading to double slashes in the resulting paths. This can break lookup in the zip file, even though there is a file at that path. By normalizing // to / the file can be read from the archive properly. On normal file systems this usually isn't a problem, because they also do this.

NeoLegends avatar Sep 10 '24 13:09 NeoLegends

This sounds like a bug in the dataset preparation pipeline?

And there are also much more cases how it could be wrong, e.g. having /// in it, or having .. in it, or whatever else. And I'm not sure to what degree we should add workarounds on RETURNN side just because you don't want to fix the bug in the dataset preparation pipeline?

albertz avatar Sep 10 '24 13:09 albertz

What is the status here? Was this just a bug in the dataset preparation pipeline, as I assumed? So then just fix the dataset preparation pipeline, and this here is not needed?

albertz avatar Oct 12 '24 09:10 albertz

Why is this still open?

albertz avatar Jun 03 '25 21:06 albertz