advanced-react-webpack-babel-setup icon indicating copy to clipboard operation
advanced-react-webpack-babel-setup copied to clipboard

Published 20 hours ago • verified publisher icon rwieruch

Add TypeScript support

Open rwieruch opened this issue 6 years ago • 5 comments

Is it possible to add TS support?

  • [ ] remove prop-types from code and package.json
  • [ ] add minimalistic typescript support
  • [ ] add type safety for title prop in src/App.js component

rwieruch avatar Oct 19 '19 23:10 rwieruch

I read your blog posts and thank you for all the tips and tricks you've been writing. Anyway, I think I can tackle this issue. Are you planning to just add type declarations or go all TypeScript by also converting the files to .ts and .tsx files?

simply-alliv avatar Oct 20 '19 15:10 simply-alliv

Converting the files would be great too. Would be awesome to see a PR coming from you!

rwieruch avatar Oct 21 '19 02:10 rwieruch

Cool beans! I had already jumped the gun earlier so I have a pull request with the required changes. I just need you to review it.

simply-alliv avatar Oct 21 '19 10:10 simply-alliv

How is it going with the PR @AlliVil :)

rwieruch avatar Oct 26 '19 06:10 rwieruch

If I'm not mistaken, I've already made a pull request.

simply-alliv avatar Oct 26 '19 20:10 simply-alliv