advisory-db icon indicating copy to clipboard operation
advisory-db copied to clipboard

retain_mut is deprecated

Open paolobarbolini opened this issue 1 year ago • 3 comments

As described in the README, retain_mut has been deprecated with the release of Rust 1.61, which stabilized Vec::retain_mut and VecDeque::retain_mut.

I see this crate still makes peaks of 30k downloads a day, with Rust 1.61 having been released almost 2 years ago. Should an advisory be made for it?

paolobarbolini avatar Mar 31 '24 14:03 paolobarbolini

Cc @upsuper

paolobarbolini avatar Mar 31 '24 14:03 paolobarbolini

The crate's README says:

This crate has been deprecated. Rust 1.61 stabilized retain_mut for Vec and VecDeque, so you can use them directly. This crate is no longer maintained.

I don't think RustSec usually carries mere deprecation warnings, but the last sentence is more relevant.

8573 avatar Apr 03 '24 04:04 8573

While I'm not sure how useful such an advisory would be, I'm not against issuing one. It is indeed unmaintained, but on the other hand, it is also very unlikely keeping the current implementation would have any security implication.

upsuper avatar Apr 03 '24 05:04 upsuper