cgmath icon indicating copy to clipboard operation
cgmath copied to clipboard

Run Rustfmt on project

Open brendanzab opened this issue 8 years ago • 3 comments

cgmath is a very old library, and has not yet had the rustfmt treatment! Most Rustaceans have it on by default in their editors, and we should make sure we can make contributing easy by running it on all our files. Unfortunately that messes up lots of formatting, especially in the matrix module.

brendanzab avatar May 13 '17 08:05 brendanzab

Hi, maybe the current parts that are not formatted can be tagged with #[rustfmt::skip] so that new code is formatted and old code is progressively formatted ? Would it be a good compromise ?

alexandre-janniaux avatar Nov 26 '19 20:11 alexandre-janniaux

@alexandre-janniaux you'd need to do fair judgement on what parts are messed up, and what parts are acceptably modified. You can make a PR and we can continue discussion there?

kvark avatar Jan 08 '20 14:01 kvark

Hi, I can give it a try, sure, can you assign me ?

alexandre-janniaux avatar Jan 08 '20 16:01 alexandre-janniaux