Rajdeep Malakar
Rajdeep Malakar
> > > You mean, the env should take priority? > > > > No, I mean if either is set, it should be on. Which is the way you...
The default behaviour (without any env or flag) is to install normally. So, if the env is set to 0, it should do that? Sorry for sounding like an idiot....
> > The default behaviour (without any env or flag) is to install normally. So, if the env is set to 0, it should do that? > > Exactly. Setting...
@jhheider implemented it, is it okay? If so, can you please test that the env works as expected? (It probably does, but still a test is a good idea)
So @jhheider anything else that's left? (Maybe check if it's by PKGX part? We can improve that) Also @mxcl can you please share thoughts?
> > 2. pkgx install now checks for pkgx (instead of exec pkgx) in a script to consider it as installed by PKGX (because unsafe installations don't use exec pkgx)...
maybe i read that proposal before coming up with this PR, and forgot about it before doing it. it is certainly inspired by your proposal. so, i think you deserve...
> > That is possible, but it'll break compatibility with the stubs installed by older versions. PKGX wouldn't detect them as installed by PKGX if we completely move to this...
does `#MANAGED BY PKGX` sound good for that comment? (it's unique enough to not cause conflicts)
> go for it! done!