rustdesk icon indicating copy to clipboard operation
rustdesk copied to clipboard

Published 20 hours ago • verified publisher icon rustdesk

Ipv6

Open fufesou opened this issue 3 years ago • 2 comments

https://github.com/rustdesk/rustdesk-server/pull/119

Not Sure

  1. Why not drop socket earlier?
  2. If rendezvous_addr is a domain string. register_pk use domain url to send a udp request. The rendezvous server may see an IPv6 or IPv4 address by occasionally. It may be caused by my cloud network provider. But it won't take any problems. The only result is from IPv6 --> IPv6 to IPv4 --> IPv4.
  3. Comment the checking socket addr logic.

Known issues

  1. Some private IPv6 is an one-way link. Only relay connection be established on those cases.
  2. No considerations about multiple network interfaces.
  3. Socks proxy does not support IPv6.

fufesou avatar Sep 21 '22 12:09 fufesou

Todo:

  • [ ] prefer to choose ipv4 first, only choose ipv6 if any side does not support ipv4. Ipv6 has a lot of limitations in practice, we have to be conservative to reduce impaction. e.g. only outbound ok, but inbound is denied always, be sure that https://github.com/rustdesk/rustdesk/blob/b6e0cc8e74188dc2ccc084adbe2bc49401518abb/src/rendezvous_mediator.rs#L380 is done correctly.

rustdesk avatar Oct 27 '22 10:10 rustdesk

prefer to choose ipv4 first, only choose ipv6 if any side does not support ipv4. Ipv6 has a lot of limitations in practice

What limitations are you speaking of?

tiagogaspar8 avatar Nov 10 '22 11:11 tiagogaspar8

  • [ ] NAT64 handeling
  • [ ] for best compatibility before full test, please prioritize v4 for the time being

rustdesk avatar Dec 03 '22 12:12 rustdesk