vhost-device icon indicating copy to clipboard operation
vhost-device copied to clipboard

build: Update vm-memory from 0.15.0 to 0.16.0

Open TimePrinciple opened this issue 1 year ago • 2 comments

Summary of the PR

  • build: Centralize rust-vmm crates to workspace
  • build: Update vm-memory from 0.15.0 to 0.16.0

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

  • [x] All commits in this PR have Signed-Off-By trailers (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
  • [ ] All added/changed functionality has a corresponding unit/integration test.
  • [ ] All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).
  • [x] Any newly added unsafe code is properly documented.

TimePrinciple avatar Oct 09 '24 18:10 TimePrinciple

It seems that's really a breaking update, I will fix this the first thing tomorrow morning 🧐

TimePrinciple avatar Oct 09 '24 18:10 TimePrinciple

Need rust-vmm/vhost#262 and rust-vmm/vm-virtio#312 to be merged and release :)

TimePrinciple avatar Oct 10 '24 06:10 TimePrinciple

I'm not sure for this workspace is a good idea. I can see the advantage, but maybe it will be hard to keep everything aligned. At the end here we have different binaries, so we can accept that they use different versions.

stefano-garzarella avatar Oct 21 '24 12:10 stefano-garzarella

I'm not sure for this workspace is a good idea. I can see the advantage, but maybe it will be hard to keep everything aligned. At the end here we have different binaries, so we can accept that they use different versions.

Noted :O, closing this

TimePrinciple avatar Oct 21 '24 13:10 TimePrinciple

I'm not sure for this workspace is a good idea. I can see the advantage, but maybe it will be hard to keep everything aligned. At the end here we have different binaries, so we can accept that they use different versions.

+1 These are binaries, not libraries.

epilys avatar Oct 22 '24 13:10 epilys