bootloader icon indicating copy to clipboard operation
bootloader copied to clipboard

Guard the lower 1MB of memory

Open jasoncouture opened this issue 2 years ago • 4 comments

This also adds a new fuction to ignore the attempts to guard the lower 1MB if it's really required.

Closes #311

jasoncouture avatar Jan 06 '23 02:01 jasoncouture

@phil-opp this is ready for review. I also added tests.

jasoncouture avatar Jan 11 '23 01:01 jasoncouture

Thanks for the updates! I left some suggestions, otherwise these changes look good to me. However, I still think that we need to ensure that we don't use the first megabyte for the kernel allocation in the UEFI loader, as I noted above:

I think the main issue is that the UEFI allocation used for loading the kernel might already use the first MB if we are unlucky. So to be safe, we would need to allocate that first megabyte before creating the allocation. We can use the "allocate at address" API mentioned in https://github.com/rust-osdev/bootloader/issues/311#issuecomment-1372193672 for that.

phil-opp avatar Jan 11 '23 11:01 phil-opp

@jasoncouture Friendly ping :). What's the status of this?

phil-opp avatar Mar 12 '23 14:03 phil-opp

@jasoncouture Friendly ping :). What's the status of this?

I'll take another look weekend after next. Got some personal things to attend for the next week or so.

jasoncouture avatar Mar 12 '23 15:03 jasoncouture

Superseded by #446

Freax13 avatar Jun 24 '24 09:06 Freax13