rustfmt
rustfmt copied to clipboard
rust-lang
fix #6164: Reduce format failure for non default `imports_granularity`
Fixed: #6164
This patch reduces format failure for non default imports_granularity and correct the behavior around some edge cases.
- Supports too long line of
use ...that contains{}. - Fixes the width calculation of too long lines of
use ....
Thank you for quick look!
I'll rethink and refactor. I'll mention once I've done.
@ytmimi Could you have a look? Thanks!
I really appreciate you taking the time to make these changes. As I mentioned in https://github.com/rust-lang/rustfmt/pull/6165#pullrequestreview-2067260236 I likely won't have time to re-review this for a little while, and I'll follow up when I can
This is a friendly ping.
Three months passed.
@ytmimi Could you have a look? Let me know if I can help.
@kenoss I know it's been some time, but I unfortunately haven't had the bandwidth. Right now my main focus is getting rustfmt ready for the upcoming edition release, mentoring the GSoC project, triaging issues, and working on smaller bugfixes. I appreciate your patience on this.
I understand your situation. (But... I wonder why don't you add more reviewers? It looks other PRs also are stuck with review.)
OK. Then, I'll pause to make this PR fresh. Let me know when you can review. Then, I'll rebase it.
@ytmimi Friendly ping in 2024 year end. I happened to notice that you are reviewing some PRs. Do you mind to take time to review this PR?
I rebased it onto near HEAD. (Commit 8a2c0739 is not working on my environment. Rebased to HEAD~.)
I replaced .offset_left() of original PR to .offset_left_opt(). (See commit 1d1fb660.)
It looks OK as this path is not yet properly result-fied. I'm willing to make use results in this path in another PR if you have review bandwidth.
Thanks.
@kenoss Thanks for taking the time to rebase the PR. At the moment this is a lower priority item for the team and I don't anticipate I'll get around to reviewing the implementation before the end of the year. It's hard to say when exactly I'll be able to revisit this one, but I'll be sure to reach out when I do.
Thank you for taking time!
FYI, it's a blocker for me to upstream it because I need it for CI. I don't want to diverge it.
Thanks! Comment added. All review comments resolved. (I'm not familiar with GitHub and a way of this repository. Which should I or you do Resolve conversation? I'll leave them.)
