rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Add `nfc_normalize_idents` flag

Open Jules-Bertholet opened this issue 1 year ago • 3 comments
trafficstars

Addresses #6058 @ytmimi

Jules-Bertholet avatar Feb 13 '24 16:02 Jules-Bertholet

@Jules-Bertholet when you have a moment can you remove the fix for https://github.com/rust-lang/rustfmt/issues/6069 from this PR and open a separate PR that independently addresses that issue.

ytmimi avatar Feb 13 '24 16:02 ytmimi

The test for the nfc_normalize_idents relies on the #6069 fix to pass (it checks that NFC-normalizing idents in trait declaration works, which relies on rustfmt not immediately crashing in that situation.) So I can split it out, but this PR will then be blocked on that one.

Jules-Bertholet avatar Feb 13 '24 16:02 Jules-Bertholet

The test for the nfc_normalize_idents relies on the https://github.com/rust-lang/rustfmt/issues/6069 fix to pass (it checks that NFC-normalizing idents in trait declaration works, which relies on rustfmt not immediately crashing in that situation.) So I can split it out, but this PR will then be blocked on that one.

Yeah, I'd rather split them out. The fix for #6069 will be easier to land, and then we can keep iterating on this new configuration.

ytmimi avatar Feb 13 '24 17:02 ytmimi