rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

Implement space_after_not option

Open x17jiri opened this issue 1 year ago • 6 comments

There has been request for this some time ago https://github.com/rust-lang/rustfmt/issues/5308

I would also like to have this option

x17jiri avatar Jan 31 '24 14:01 x17jiri

Thanks for the PR. Going to mark this one as on hold for now. There was some discussion back in https://github.com/rust-lang/rustfmt/issues/5308, where we were unsure if we should add this option. Again, I want to thank you for stepping up to work on this. We'll follow up once we've had a chance to discuss this one.

ytmimi avatar Feb 18 '24 18:02 ytmimi

@ytmimi Sure. Is there something I can help with in the meantime?

x17jiri avatar Feb 22 '24 17:02 x17jiri

@x17jiri not at this time. This is something that the team needs to discuss to unblock. I brought this up for discussion in our last team meeting, but it hasn't been addressed yet because the team couldn't meet at the scheduled time. The discussion might continue on the linked thread, but if it doesn't I'll do my best to bring this one up again during our next team meeting

ytmimi avatar Feb 22 '24 18:02 ytmimi

@ytmimi Sure. Is there something I can help with in the meantime?

@x17jiri my last comment was referring to this one being blocked until the team has a chance to discuss this, but I'm now realizing that maybe you were asking about helping out with other issues. If that's the case, then I'm sure I could point you in the right direction!

ytmimi avatar Feb 22 '24 19:02 ytmimi

@ytmimi

my last comment was referring to this one being blocked until the team has a chance to discuss this, but I'm now realizing that maybe you were asking about helping out with other issues. If that's the case, then I'm sure I could point you in the right direction!

Yes, that's what I meant :-)

x17jiri avatar Feb 22 '24 19:02 x17jiri

Yes, that's what I meant :-)

Fantastic! I'll dig through the backlog when I've got a little more free time and tag you in one or two issues that I think would be a good fit for a new contributor.

ytmimi avatar Feb 22 '24 20:02 ytmimi