rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

Impl `StyleEditionDefault` trait for all configs

Open ytmimi opened this issue 2 years ago • 3 comments
trafficstars

This PR is a follow up to https://github.com/rust-lang/rustfmt/pull/5933, ~~but currently includes all the changes from that PR since it hasn't been merged yet~~.

This PR makes internal changes to define each configuration in terms of the StyleEditionDefault trait, and hard codes StyleEdition::Edition2015 anywhere the new style_edition is needed.

Note users are still unable to configure style edition.

r? @calebcartwright

Edit: https://github.com/rust-lang/rustfmt/pull/5933 was merged and I rebased this PR.

ytmimi avatar Oct 08 '23 23:10 ytmimi

@ytmimi do you think this would be better to merge before or after the next sync? (no promises but I'm going to try to do one today)

calebcartwright avatar Apr 07 '24 18:04 calebcartwright

@calebcartwright If we're going to do a sync we should update the changelog. I've started that on #6004, but there are a few other fixes that I merged that don't have entries yet.

ytmimi avatar Apr 07 '24 19:04 ytmimi

That said, we can probably wait to merge this until after the sync

ytmimi avatar Apr 07 '24 19:04 ytmimi