rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

config: Stabilize binop_separator again.

Open emilio opened this issue 3 years ago • 12 comments
trafficstars

See reasoning in #4144, which still applies. Other projects like bindgen etc also use it by default, and this would allow them to move to stable rust.

Fixes #3368 again.

emilio avatar Sep 28 '22 01:09 emilio

@ytmimi review ping?

emilio avatar Dec 19 '22 10:12 emilio

@calebcartwright do you think we're ready to stabilize this option again?

ytmimi avatar Feb 03 '23 15:02 ytmimi

@calebcartwright do you think we're ready to stabilize this option again?

Yes I believe so. Would you mind doing a quick scan through the issue tracker to make sure there aren't any 1.x bugs that would be relevant here that weren't relevant for the 2.x stabilization?

calebcartwright avatar Feb 03 '23 16:02 calebcartwright

Ping here?

emilio avatar Mar 11 '23 00:03 emilio

@emilio thanks for reaching out to put this back on the team's radar. We're currently focused on some higher priority items like let-else formatting, and we'll get back to this stabilization request at some point after those are completed. I very much appreciate your patience on this.

ytmimi avatar Mar 13 '23 16:03 ytmimi

Thanks for the update!

emilio avatar Mar 15 '23 20:03 emilio

Gentle ping? @ytmimi

emilio avatar Aug 24 '23 18:08 emilio

Rebased

emilio avatar Nov 20 '23 10:11 emilio

@calebcartwright / @ytmimi, any chance of getting this merged? I don't see any relevant issue in the tracker about this option after a quick scan, and this makes Servo and Firefox need nightly rustfmt but stable rust, which is kind of annoying... :)

emilio avatar Feb 26 '24 09:02 emilio

(Plus we've been using this option for ~ever, without any issue)

emilio avatar Feb 26 '24 10:02 emilio

Hey @emilio thanks for reaching out again and sorry that this one still hasn't gotten much attention from the team. I'm going to bring this up for discussion in our next team meeting.

ytmimi avatar Feb 26 '24 16:02 ytmimi