rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

Incorrect path printed on error

Open nazar-pc opened this issue 3 years ago • 4 comments
trafficstars

nazar-pc@nazar-pc:/w/s/subspace> rustfmt --version
rustfmt 1.5.1-nightly (62b272d 2022-07-21)
nazar-pc@nazar-pc:/w/s/subspace> rustfmt --config error_on_line_overflow=true crates/pallet-subspace/src/lib.rs
error[internal]: line formatted, but exceeded maximum width (maximum: 100 (see `max_width` option), found: 105)
   --> /web/subspace/subspace/crates/pallet-subspace/src/lib.rs:478:478:101
    |
478 |         #[pallet::weight((<T as Config>::WeightInfo::report_equivocation(), DispatchClass::Operational))]
    |                                                                                                     ^^^^^
    |

error[internal]: line formatted, but exceeded maximum width (maximum: 100 (see `max_width` option), found: 128)
   --> /web/subspace/subspace/crates/pallet-subspace/src/lib.rs:493:493:101
    |
493 |         #[pallet::weight((<T as Config>::WeightInfo::store_root_blocks(root_blocks.len()), DispatchClass::Mandatory, Pays::No))]
    |                                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |

warning: rustfmt has failed to format. See previous 2 errors.

This is inconvenient when I want to open the file at that line in IDE afterwards.

nazar-pc avatar Jul 24 '22 00:07 nazar-pc

Yeah that's odd. Just double checking that you're referring to /web/subspace/subspace/crates/pallet-subspace/src/lib.rs:478:478:101?

ytmimi avatar Jul 27 '22 03:07 ytmimi

Yes

nazar-pc avatar Jul 27 '22 04:07 nazar-pc

Not knowing the ins and outs of your local file system, are you saying that /web/subspace/subspace/crates/pallet-subspace/src/lib.rs is not a correct, absolute path to the file?

calebcartwright avatar Aug 07 '22 02:08 calebcartwright

I should have been clearer, the issue is not the path of the file itself, but rather location in the file.

478:478:101 should have been 478:101.

nazar-pc avatar Aug 07 '22 02:08 nazar-pc