rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

fixes #5234

Open andrewgazelka opened this issue 3 years ago • 4 comments

Fixes #5234

This will also change

'''

'''

to

'''
'''

where ''' represents backticks

andrewgazelka avatar Feb 22 '22 22:02 andrewgazelka

Hey @andrewgazelka, thanks for taking the time to work on this PR, and for your first contribution to rustfmt!!

Just want to acknowledge that I've seen this and I'll try to do a thorough review soon.

ytmimi avatar Feb 23 '22 01:02 ytmimi

Believe this is another approach as #4902 which was to address #4793. Haven't looked closely enough at either to speak to the different approaches but sharing for reference and awareness

calebcartwright avatar Feb 23 '22 03:02 calebcartwright

@calebcartwright thanks for pointing that out. When I have a chance to review this PR I'll make sure to take a look at those links!

ytmimi avatar Feb 23 '22 13:02 ytmimi

@ytmimi is this one you were still planning on taking a look at? if so feel free to assign to yourself (will be a helpful indicator for me :smile:)

calebcartwright avatar Apr 28 '22 00:04 calebcartwright

Thanks again for opening this PR, but going to close this in favor of #5601, which has a simpler implementation

ytmimi avatar Nov 20 '22 00:11 ytmimi