rustfmt
rustfmt copied to clipboard
rust-lang
Not moving the first line comment of blocks
Thank you! My review queue is pretty backed up right now, but I'm really looking forward to this one. The current behavior that breaks the comment association in these cases is a common source of frustration for users, so there will be a lot of folks that will really appreciate this!
I just ran into #3255. Is there any way to move this PR forward? It looks like it's labeled p-low because it's targetting 2.0.
A comment in #3887 says:
To be perfectly transparent though, rustfmt 2.0 may not happen ever, but even if it does it certainly won't happen any time soon. If and when there will be a 2.0, rest assured that will be communicated loudly and broadly. Until then I'd suggest largely forgetting about it and working with the 1.x versions of rustfmt available today.
Does that mean this PR is simply not happening?
Does that mean this PR is simply not happening?
Yes and no. It does mean this specific PR isn't going to get merged given the target branch, but the proposed changes could be merged if someone wants to pick them up and target the correct/master/1.x branch