rust icon indicating copy to clipboard operation
rust copied to clipboard

Implement representation options to smir

Open ShoyuVanilla opened this issue 6 months ago • 7 comments

Resolves rust-lang/project-stable-mir#89

ShoyuVanilla avatar Jun 03 '25 04:06 ShoyuVanilla

r? @scottmcm

rustbot has assigned @scottmcm. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Jun 03 '25 04:06 rustbot

Oh, it seems that rustbot randomly assigns reviewer instead of code owners. Sorry 😅

r? @celinval

ShoyuVanilla avatar Jun 03 '25 04:06 ShoyuVanilla

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
--- stderr -------------------------------
warning: variable does not need to be mutable
##[warning]  --> alloc_input.rs:16:56
   |
16 |         pub unsafe extern "C" fn variadic_fn(n: usize, mut args: ...) -> usize {
   |                                                        ----^^^^
   |                                                        |
   |                                                        help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default

rust-log-analyzer avatar Jun 03 '25 08:06 rust-log-analyzer

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
--- stderr -------------------------------
warning: variable does not need to be mutable
##[warning]  --> alloc_input.rs:16:56
   |
16 |         pub unsafe extern "C" fn variadic_fn(n: usize, mut args: ...) -> usize {
   |                                                        ----^^^^
   |                                                        |
   |                                                        help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default

rust-log-analyzer avatar Jun 03 '25 09:06 rust-log-analyzer

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
--- stderr -------------------------------
warning: variable does not need to be mutable
##[warning]  --> alloc_input.rs:16:56
   |
16 |         pub unsafe extern "C" fn variadic_fn(n: usize, mut args: ...) -> usize {
   |                                                        ----^^^^
   |                                                        |
   |                                                        help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default

rust-log-analyzer avatar Jun 03 '25 16:06 rust-log-analyzer

@bors r+ rollup

oli-obk avatar Jun 10 '25 14:06 oli-obk

:pushpin: Commit dabed3372c9f57398ac9a33f2c9d03ab3d4ab43f has been approved by oli-obk

It is now in the queue for this repository.

bors avatar Jun 10 '25 14:06 bors

@bors rollup=iffy

workingjubilee avatar Jun 11 '25 04:06 workingjubilee

:hourglass: Testing commit dabed3372c9f57398ac9a33f2c9d03ab3d4ab43f with merge 0a39445252ac076ef573bcacee63bbdc59497b52...

bors avatar Jun 11 '25 07:06 bors

:sunny: Test successful - checks-actions Approved by: oli-obk Pushing 0a39445252ac076ef573bcacee63bbdc59497b52 to master...

bors avatar Jun 11 '25 11:06 bors

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2b0274c71dba0e24370ebf65593da450e2e91868 (parent) -> 0a39445252ac076ef573bcacee63bbdc59497b52 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0a39445252ac076ef573bcacee63bbdc59497b52 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 9159.1s -> 13442.3s (46.8%)
  2. mingw-check-1: 1968.4s -> 1611.3s (-18.1%)
  3. dist-aarch64-apple: 6470.8s -> 5558.2s (-14.1%)
  4. i686-gnu-2: 6192.5s -> 5378.4s (-13.1%)
  5. i686-gnu-1: 8247.0s -> 7210.6s (-12.6%)
  6. aarch64-gnu-debug: 4179.1s -> 3710.0s (-11.2%)
  7. armhf-gnu: 5021.3s -> 4496.5s (-10.5%)
  8. mingw-check-tidy: 66.6s -> 73.1s (9.7%)
  9. x86_64-gnu-llvm-19-1: 3611.0s -> 3309.1s (-8.4%)
  10. dist-armv7-linux: 4978.3s -> 5391.9s (8.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance that executed the job, system noise, invalidated caches, etc. The table above is provided mostly for t-infra members, for simpler debugging of potential CI slow-downs.

github-actions[bot] avatar Jun 11 '25 11:06 github-actions[bot]

Finished benchmarking commit (0a39445252ac076ef573bcacee63bbdc59497b52): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.4%, secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-6.0%, -0.8%] 22
Improvements ✅
(secondary)
-2.7% [-9.3%, -0.7%] 79
All ❌✅ (primary) -2.4% [-6.0%, -0.8%] 22

Cycles

Results (secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.155s -> 754.356s (0.03%) Artifact size: 372.17 MiB -> 372.07 MiB (-0.02%)

rust-timer avatar Jun 11 '25 16:06 rust-timer