rust icon indicating copy to clipboard operation
rust copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

CFI: Break tests into smaller files

Open rcvalle opened this issue 1 year ago • 6 comments
trafficstars

Breaks type metadata identifiers tests into smaller set of tests/files.

rcvalle avatar Mar 12 '24 10:03 rcvalle

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Mar 12 '24 10:03 rustbot

r? @compiler-errors

rcvalle avatar Mar 12 '24 10:03 rcvalle

Can you take all the tests prefixed cfi and move them into a cfi/ subdirectory?

compiler-errors avatar Mar 12 '24 14:03 compiler-errors

Can you take all the tests prefixed cfi and move them into a cfi/ subdirectory?

Done. (I also moved all KCFI tests to a kcfi subdirectory.)

rcvalle avatar Mar 12 '24 15:03 rcvalle

@bors r+ rollup

compiler-errors avatar Mar 12 '24 18:03 compiler-errors

:pushpin: Commit 304d3e118ad95a3286c1375ffe38f828b003316c has been approved by compiler-errors

It is now in the queue for this repository.

bors avatar Mar 12 '24 18:03 bors

@bors r- https://github.com/rust-lang/rust/pull/122417#issuecomment-1993552623

matthiaskrgr avatar Mar 13 '24 05:03 matthiaskrgr

@bors r- #122417 (comment)

Fixed. Sorry for the trouble.

rcvalle avatar Mar 13 '24 09:03 rcvalle

@bors r=compiler-errors

matthiaskrgr avatar Mar 13 '24 17:03 matthiaskrgr

:pushpin: Commit bf718253010dc0b0fdd8378fdf2c5c2574e27865 has been approved by compiler-errors

It is now in the queue for this repository.

bors avatar Mar 13 '24 17:03 bors

@bors r- rollup=iffy https://github.com/rust-lang/rust/pull/122457#issuecomment-1996051828

matthiaskrgr avatar Mar 14 '24 03:03 matthiaskrgr

Some changes occurred in tests/codegen/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

rustbot avatar Mar 14 '24 07:03 rustbot

@rustbot ready

matthiaskrgr avatar Mar 18 '24 21:03 matthiaskrgr

@bors r+

compiler-errors avatar Mar 19 '24 02:03 compiler-errors

:pushpin: Commit 6bd85c4de4c2f4c53628cdedf8c412a58e366679 has been approved by compiler-errors

It is now in the queue for this repository.

bors avatar Mar 19 '24 02:03 bors

:hourglass: Testing commit 6bd85c4de4c2f4c53628cdedf8c412a58e366679 with merge 148a41c6b5687f941c5256d9ef8145eb03b72094...

bors avatar Mar 19 '24 02:03 bors

:sunny: Test successful - checks-actions Approved by: compiler-errors Pushing 148a41c6b5687f941c5256d9ef8145eb03b72094 to master...

bors avatar Mar 19 '24 04:03 bors

Finished benchmarking commit (148a41c6b5687f941c5256d9ef8145eb03b72094): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.2% [-6.2%, -6.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.9% [2.4%, 9.3%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.018s -> 667.92s (-0.31%) Artifact size: 312.86 MiB -> 312.84 MiB (-0.00%)

rust-timer avatar Mar 19 '24 05:03 rust-timer