rust
rust copied to clipboard
Revert "Auto merge of #122140 - oli-obk:track_errors13, r=davidtwco"
This reverts commit 65cd843ae06ad00123c131a431ed5304e4cd577a, reversing changes made to d255c6a57c393db6221b1ff700daea478436f1cd.
reverts https://github.com/rust-lang/rust/pull/122140
It was a large regression in wall time due to trashing CPU caches
@bors rollup=never
r? @michaelwoerister
rustbot has assigned @michaelwoerister. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@bors r+
:pushpin: Commit 96d24f2dd13e8e9d0c6f9912781ffe1fc79864d3 has been approved by compiler-errors
It is now in the queue for this repository.
:hourglass: Testing commit 96d24f2dd13e8e9d0c6f9912781ffe1fc79864d3 with merge 5ac0b2d0219de2fd6fef86c69ef0cfa1e6c36f3b...
:sunny: Test successful - checks-actions Approved by: compiler-errors Pushing 5ac0b2d0219de2fd6fef86c69ef0cfa1e6c36f3b to master...
Finished benchmarking commit (5ac0b2d0219de2fd6fef86c69ef0cfa1e6c36f3b): comparison URL.
Overall result: ❌✅ regressions and improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is a highly reliable metric that was used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
0.2% | [0.2%, 0.2%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-0.9% | [-0.9%, -0.9%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.3% | [-0.9%, 0.2%] | 2 |
Max RSS (memory usage)
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
2.0% | [0.8%, 3.2%] | 4 |
| Regressions ❌ (secondary) |
4.7% | [4.7%, 4.7%] | 1 |
| Improvements ✅ (primary) |
-2.9% | [-2.9%, -2.9%] | 1 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 1.0% | [-2.9%, 3.2%] | 5 |
Cycles
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
1.7% | [1.7%, 1.7%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-4.1% | [-12.3%, -1.3%] | 60 |
| Improvements ✅ (secondary) |
-10.3% | [-19.0%, -2.1%] | 19 |
| All ❌✅ (primary) | -4.0% | [-12.3%, 1.7%] | 61 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 677.02s -> 667.978s (-1.34%) Artifact size: 310.67 MiB -> 310.75 MiB (0.03%)