rust icon indicating copy to clipboard operation
rust copied to clipboard

Be careful about `expr_ty_adjusted` when noting block tail type

Open compiler-errors opened this issue 3 years ago • 3 comments

Fixes #101623

compiler-errors avatar Sep 09 '22 19:09 compiler-errors

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Sep 09 '22 19:09 rust-highfive

@bors r+

sanxiyn avatar Sep 18 '22 13:09 sanxiyn

:pushpin: Commit 44738ee336f72e683b2c24dac22b919567ec03a7 has been approved by sanxiyn

It is now in the queue for this repository.

bors avatar Sep 18 '22 13:09 bors

:hourglass: Testing commit 44738ee336f72e683b2c24dac22b919567ec03a7 with merge d7922d3b8e798386b12d93d2b6622f877328719e...

bors avatar Sep 19 '22 01:09 bors

:broken_heart: Test failed - checks-actions

bors avatar Sep 19 '22 02:09 bors

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
error: could not execute process `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/tmp/cit/t2437/lib/./foo -vV` (never executed)
Caused by:
  Text file busy (os error 26)
', src/tools/cargo/tests/testsuite/workspaces.rs:2176:42

---
test result: FAILED. 2467 passed; 1 failed; 142 ignored; 0 measured; 0 filtered out; finished in 79.49s

error: test failed, to rerun pass '--test testsuite'
Build completed unsuccessfully in 0:21:42
make: *** [Makefile:44: check-aux] Error 1

rust-log-analyzer avatar Sep 19 '22 06:09 rust-log-analyzer

@bors retry the test failure doesn't look related

compiler-errors avatar Sep 19 '22 07:09 compiler-errors

:hourglass: Testing commit 44738ee336f72e683b2c24dac22b919567ec03a7 with merge 503e19d01e941b88bf6d5b28e9108d046abcfa2d...

bors avatar Sep 19 '22 07:09 bors

:sunny: Test successful - checks-actions Approved by: sanxiyn Pushing 503e19d01e941b88bf6d5b28e9108d046abcfa2d to master...

bors avatar Sep 19 '22 10:09 bors

Finished benchmarking commit (503e19d01e941b88bf6d5b28e9108d046abcfa2d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [4.1%, 4.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean[^1] range count[^2]
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

[^1]: the arithmetic mean of the percent change [^2]: number of relevant changes

rust-timer avatar Sep 19 '22 12:09 rust-timer