rust-playground icon indicating copy to clipboard operation
rust-playground copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Support non-ASCII identifiers in syntax highlighting

Open Alphare opened this issue 4 years ago • 5 comments

https://github.com/rust-lang/rust/pull/83799 has been stabilized in 1.53, which means that my first name is now a valid Rust identifier. While this is great news, turns out that only rapha in raphaël is highlighted as a function name.

I am not sure how this is implemented now, but I suspect the regex needs to be adjusted to accept all valid unicode characters under this new feature.

Alphare avatar Jun 17 '21 15:06 Alphare

You will need to submit a pull request to the Ace editor.

shepmaster avatar Jun 17 '21 16:06 shepmaster

Sorry, I forgot about this. Will do, thanks. :)

Alphare avatar Jun 23 '21 12:06 Alphare

Opened https://github.com/ajaxorg/ace/issues/4519, thanks.

Alphare avatar Jun 23 '21 12:06 Alphare

I like to leave these open to keep tabs on things we will need to update eventually. 😉

shepmaster avatar Jun 23 '21 17:06 shepmaster

Looks like the upstream issue has been fixed!

camelid avatar Sep 05 '21 02:09 camelid