rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Add new lint `unneeded_struct_pattern`

Open SpriteOvO opened this issue 1 year ago • 4 comments

Closes #13400.

changelog: [unneeded_struct_pattern]: Add new lint

SpriteOvO avatar Sep 26 '24 19:09 SpriteOvO

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Sep 26 '24 19:09 rustbot

:umbrella: The latest upstream changes (presumably #13334) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 13 '24 07:10 bors

Rebased. r? @alex-semenyuk

SpriteOvO avatar Oct 15 '24 18:10 SpriteOvO

Failed to set assignee to alex-semenyuk: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot avatar Oct 15 '24 18:10 rustbot

:umbrella: The latest upstream changes (presumably #13376) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Nov 02 '24 12:11 bors

Hey @SpriteOvO, been almost a month and I'm pinging from triage. Has there been any progress? Is there anything you're stuck on or have any questions?

Centri3 avatar Dec 02 '24 03:12 Centri3

@Centri3 Oh, sorry, I totally missed this in my inbox. I'll finish it in the next days.

SpriteOvO avatar Dec 02 '24 07:12 SpriteOvO

Oop, forgot FCP again -w- I'll open a thread regardless (I am doubtful there'd be pushback in any case.)

Centri3 avatar Jan 12 '25 02:01 Centri3

FCP? opened for any comments on a follow-up PR or anything: https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/FCP.3F.3A.20.60unneeded_struct_pattern.60

Centri3 avatar Jan 12 '25 03:01 Centri3