libc icon indicating copy to clipboard operation
libc copied to clipboard

Add fcntl OFD commands for macOS

Open anacrolix opened this issue 1 year ago • 10 comments

I also followed all the PR instructions and sorted the semver for apple.

anacrolix avatar Jan 27 '24 23:01 anacrolix

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

rustbot avatar Jan 27 '24 23:01 rustbot

So I noticed that the tests run on macos-13, and macos-14 is available (possibly needed for the OFD feature, despite the constants being 4 years old according to the kernel changelog), and also that the tests only run on Intel chips. I do not think it would be too much work to add aarch64 to the macos testing (assuming GitHub has a runner for this).

anacrolix avatar Jan 28 '24 00:01 anacrolix

Could you rebase onto the latest main and squash commits into one?

JohnTitor avatar Jan 28 '24 05:01 JohnTitor

Yes, I'll do that soon, thanks.

anacrolix avatar Feb 09 '24 05:02 anacrolix

Okay, I've done that. It's extraordinarily painful, any reason you can't squash on merge?

anacrolix avatar Feb 09 '24 05:02 anacrolix

I don't think my change caused the macOS CI failure, I'm not sure what to do about that one.

anacrolix avatar Feb 09 '24 06:02 anacrolix

I don't think my change caused the macOS CI failure, I'm not sure what to do about that one.

You updated the macOS version and it introduced some breaking changes, you have to account for that.

Okay, I've done that. It's extraordinarily painful, any reason you can't squash on merge?

We use the merge queue and it doesn't allow me to select the merge method sadly.

JohnTitor avatar Feb 10 '24 02:02 JohnTitor

It'll take someone more knowledgable about macos to fix this I think. I didn't find anything straightforward to resolve it.

anacrolix avatar Feb 11 '24 12:02 anacrolix

I found https://github.com/rust-lang/libc/pull/3575 but it's mysteriously closed.

anacrolix avatar Feb 11 '24 12:02 anacrolix

This includes https://github.com/rust-lang/libc/pull/3578 and should be merged after that.

anacrolix avatar Jul 18 '24 23:07 anacrolix

@anacrolix please rebase and drop the commits that are no longer needed (1a8e6f490df340ab080ca3507fc91178de7dfc5a, cb7d5b13877695b6ee082a59ea712fa431005cb7).

@rustbot author

tgross35 avatar Aug 13 '24 01:08 tgross35

Roger

anacrolix avatar Aug 13 '24 01:08 anacrolix

@tgross35 Done

anacrolix avatar Aug 13 '24 01:08 anacrolix

There is also an empty change to ci/style.sh, can you drop that?

tgross35 avatar Aug 13 '24 01:08 tgross35