libc icon indicating copy to clipboard operation
libc copied to clipboard

[libc-0.2] Freebsd Netlink support backported

Open ydirson opened this issue 1 year ago • 4 comments

This is a proposal to bring #3201 and #3367 to libc-0.2 branch, by hiding this change behind a feature flag as suggested by @asomers in https://github.com/rust-lang/libc/pull/3367#issuecomment-1860931763.

This makes it possible to build on FreeBSD 13 eg. sysinfo v0.30.5 from @GuillaumeGomez it the feature flag is not specified, and to build rtnetlink from PR https://github.com/rust-netlink/rtnetlink/pull/49 if it is specified.

ydirson avatar Jan 22 '24 17:01 ydirson

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Jan 22 '24 17:01 rustbot

:umbrella: The latest upstream changes (presumably #3589) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Feb 18 '24 15:02 bors

Rebased.

Is there anything I can do to make this PR go forward?

ydirson avatar Feb 19 '24 11:02 ydirson

Rebased to allow replacing current version with cargo patch: 0.2.155

ydirson avatar May 22 '24 08:05 ydirson