libc icon indicating copy to clipboard operation
libc copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

adding tcp_info struct to linux musl/glibc.

Open devnexen opened this issue 1 year ago • 18 comments

devnexen avatar Dec 15 '23 10:12 devnexen

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

rustbot avatar Dec 15 '23 10:12 rustbot

@bors r+

JohnTitor avatar Dec 15 '23 14:12 JohnTitor

:pushpin: Commit 89df119924ebab05b5332d0c73c94e4a137b9247 has been approved by JohnTitor

It is now in the queue for this repository.

bors avatar Dec 15 '23 14:12 bors

:hourglass: Testing commit 89df119924ebab05b5332d0c73c94e4a137b9247 with merge 28aeb23a2de7786fcb2d4ce06ffabf725c184260...

bors avatar Dec 15 '23 16:12 bors

:broken_heart: Test failed - checks-actions

bors avatar Dec 15 '23 16:12 bors

:umbrella: The latest upstream changes (presumably #3486) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Dec 19 '23 12:12 bors

@bors r+

JohnTitor avatar Dec 20 '23 13:12 JohnTitor

:pushpin: Commit 97a839d7b71b59f1a5ecd6cf7fd25147005d828b has been approved by JohnTitor

It is now in the queue for this repository.

bors avatar Dec 20 '23 13:12 bors

:hourglass: Testing commit 97a839d7b71b59f1a5ecd6cf7fd25147005d828b with merge 3c6c040e8453c9a7940002c1ea362665408925ff...

bors avatar Dec 20 '23 14:12 bors

:broken_heart: Test failed - checks-actions

bors avatar Dec 20 '23 14:12 bors

Could you check the CI failure? Seems musl gets confused 🤔

JohnTitor avatar Dec 24 '23 00:12 JohnTitor

@bors r+

JohnTitor avatar Dec 29 '23 01:12 JohnTitor

:pushpin: Commit 4234bd2b259ff2a6992552df05d1ac0dd82ba876 has been approved by JohnTitor

It is now in the queue for this repository.

bors avatar Dec 29 '23 01:12 bors

:hourglass: Testing commit 4234bd2b259ff2a6992552df05d1ac0dd82ba876 with merge bef39f2326d56ca2185068c74dddf062e8737951...

bors avatar Dec 29 '23 01:12 bors

:broken_heart: Test failed - checks-actions

bors avatar Dec 29 '23 01:12 bors

Could you fix the CI failure? @rustbot author

JohnTitor avatar Jan 04 '24 09:01 JohnTitor

shame on me I did not realise the existence of ci shell scripts until now, pretty helpful.

devnexen avatar Jan 04 '24 13:01 devnexen

:umbrella: The latest upstream changes (presumably #3213) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Jan 08 '24 15:01 bors

@devnexen I think this looks pretty good, could you rebase? And then @rustbot review

tgross35 avatar Aug 29 '24 11:08 tgross35

@rustbot review

devnexen avatar Sep 01 '24 07:09 devnexen

Checking headers https://github.com/kraj/glibc/blob/1927f718fcc48bdaea03086bdc2adf11279d655b/sysdeps/gnu/netinet/tcp.h#L226-L267 and https://github.com/kraj/musl/blob/2c41ee96f60074fa8ac387e1fcdedba0654fb173/include/netinet/tcp.h#L195-L250 this looks good, with some notes above.

@rustbot author since I think this might need a change for the bitfield

tgross35 avatar Sep 03 '24 04:09 tgross35

Thanks!

@rustbot label +stable-nominated

tgross35 avatar Sep 03 '24 19:09 tgross35