libc
libc copied to clipboard
rust-lang
Remove "placeholder constants"
It's common for C APIs to define constant values to denote the "last" value in a set of constants, like ELAST or IPPROTO_MAX. This seems prone to weird bugs, and these constants provide very marginal benefit to Rust programmers. Since we're considering some breakage anyways, we should just remove these values where we are made aware of them.
See:
- https://github.com/rust-lang/libc/issues/1896
- https://github.com/rust-lang/libc/pull/3040
Noticed that we have a lot of *MAX consts and deprecating manually is quite hard. We could write a script but it can cause a false positive, hmm. For now, I've edited the PR template to mention this concern.
An alternative to deleting these placeholder constants would be to still provide them but not make any guarantees about their value moving forward. This means that we would be free to change the value of these constants without it being considered a breaking change.
CI tests should specifically exclude these, although it would be nice to make CI fail only if our value for such constants is lower than the one on the system.
