libc icon indicating copy to clipboard operation
libc copied to clipboard

Use Rust union types

Open kellda opened this issue 4 years ago • 17 comments

For #1020

Replace some types with unions now that rustc supports them.

I also found sigevent.sigev_notify_thread_id, siginfo_t.__data and sigaction.sa_sigaction that I think should be unions, but I wasn't sure.

kellda avatar Feb 04 '21 15:02 kellda

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Feb 04 '21 15:02 rust-highfive

Also I had to ignore iffaddrs.ifa_ifu on Linux to pass CI

kellda avatar Feb 04 '21 16:02 kellda

Unfortunately I believe this is a breaking change, which means we can't actually do this until we bump the crate version to 1.0.

cc @JohnTitor

Amanieu avatar Feb 04 '21 18:02 Amanieu

I'm aware that it is a breaking change and that's not a problem for me to wait until a new major version for this to be merged.

kellda avatar Feb 04 '21 19:02 kellda

:umbrella: The latest upstream changes (presumably #1975) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Feb 13 '21 22:02 bors

@kellda main is now intended for libc 1.0. Are you able to rebase this?

@rustbot author

tgross35 avatar Aug 29 '24 03:08 tgross35

Some changes occurred in solarish module

cc @jclulow, @pfmooney

rustbot avatar Aug 29 '24 18:08 rustbot

I'm unsure how to find out what's wrong with sigval on emscripten...

kellda avatar Aug 29 '24 19:08 kellda

Btw, I noted (when I originally opened this PR) that the following fields may also be wroth considering turning into unions:

  • sigevent.sigev_notify_thread_id
  • siginfo_t.{_pad/__data}
  • sigaction.sa_sigaction

kellda avatar Aug 29 '24 19:08 kellda