libc
libc copied to clipboard
Use Rust union types
For #1020
Replace some types with unions now that rustc supports them.
I also found sigevent.sigev_notify_thread_id, siginfo_t.__data and sigaction.sa_sigaction that I think should be unions, but I wasn't sure.
r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)
Also I had to ignore iffaddrs.ifa_ifu on Linux to pass CI
Unfortunately I believe this is a breaking change, which means we can't actually do this until we bump the crate version to 1.0.
cc @JohnTitor
I'm aware that it is a breaking change and that's not a problem for me to wait until a new major version for this to be merged.
:umbrella: The latest upstream changes (presumably #1975) made this pull request unmergeable. Please resolve the merge conflicts.
@kellda main is now intended for libc 1.0. Are you able to rebase this?
@rustbot author
Some changes occurred in solarish module
cc @jclulow, @pfmooney
I'm unsure how to find out what's wrong with sigval on emscripten...
Btw, I noted (when I originally opened this PR) that the following fields may also be wroth considering turning into unions:
- sigevent.sigev_notify_thread_id
- siginfo_t.{_pad/__data}
- sigaction.sa_sigaction