cargo icon indicating copy to clipboard operation
cargo copied to clipboard

fix(env): cargo:rerun-if-env-changed doesn't work with env configuration

Open heisen-li opened this issue 1 year ago • 5 comments
trafficstars

What does this PR try to resolve?

Fixes https://github.com/rust-lang/cargo/issues/10358 Fixes #8693

Additional information

Due to my stupidity, I screwed up the previous PR. I didn't know what to do with it, so I created a new PR.

r?@epage

heisen-li avatar Jun 13 '24 11:06 heisen-li

btw I believe this would also fix #8693.

This would likely need to revert #12482.

epage avatar Jun 26 '24 13:06 epage

I'm not clear, how does this fix #8693?

ehuss avatar Jul 24 '24 23:07 ehuss

@heisen-li Do you plan on finishing this up? It would be great to see this land.

MabezDev avatar Sep 11 '24 18:09 MabezDev

@heisen-li Do you plan on finishing this up? It would be great to see this land.

I may not have time for this for a while due to changes in my job and the difficulty of modifying this PR which may take more time for me.If you or anyone else is interested feel free to finish and close this.If I have more time I would be more than happy to continue this work.Sorry about that.

heisen-li avatar Sep 12 '24 07:09 heisen-li

:umbrella: The latest upstream changes (presumably #14137) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Oct 08 '24 21:10 bors

No worries @heisen-li. Your help here is appreciated. I'll close this in favor of #14756. Thanks you!

weihanglo avatar Nov 01 '24 23:11 weihanglo