book icon indicating copy to clipboard operation
book copied to clipboard

Adaptor/Adapter Inconsistency

Open SpectralPixel opened this issue 1 year ago • 4 comments
trafficstars

  • I have searched open and closed issues and pull requests for duplicates, using these search terms:
    • American (desired result: something along the lines of "American/English spelling inconsistency")
    • inconsistency
    • adaptor
    • adapter
  • I have checked the latest main branch to see if this has already been fixed, in this file:
    • https://github.com/rust-lang/book/blob/main/src/ch13-02-iterators.md

URL to the section(s) of the book with this problem: The only appearance of this problem is in https://doc.rust-lang.org/book/ch13-02-iterators.html#using-closures-that-capture-their-environment, twice in the first paragraph of this section.

Description of the problem: -> Throughout the page 13.2. Processing a Series of Items with Iterators the U.K. spelling "adaptor" is much more prominent than the U.S. spelling, which is "adapter". The U.S. spelling only appears twice at the beginning of the "Using Closures that Capture Their Environment".

Suggested fix: Change those two instances from "adapter" to "adaptor".

SpectralPixel avatar Jan 22 '24 17:01 SpectralPixel

The main problem I have with this is the standard library docs use "adapter" -- https://doc.rust-lang.org/std/iter/index.html#adapters

carols10cents avatar Jan 22 '24 17:01 carols10cents

See https://github.com/rust-lang/rust/pull/87629

carols10cents avatar Jan 22 '24 17:01 carols10cents

I see. In that case it might make more sense to replace all instances of "adaptor" (U.K.) with "adapter" (U.S.). This is a much bigger issue than I originally thought, though it shouldn't be difficult to patch up.

SpectralPixel avatar Jan 22 '24 19:01 SpectralPixel

@carols10cents it looks like this got un-blocked upstream back in 2021, so should we go ahead with flipping it for the 2024 edition?

chriskrycho avatar Mar 29 '24 14:03 chriskrycho