ac-library-rs

ac-library-rs copied to clipboard

Suppress some annoying lints in what way

4

> BTW, how do we suppress [`clippy::many_single_char_names`](https://rust-lang.github.io/rust-clippy/rust-1.42.0/#many_single_char_names)? Adding `#![allow]` to each module, or the crate root? > > ```rust > #![allow(clippy::many_single_char_names)] > ``` _Originally posted by @qryxip in https://github.com/rust-lang-ja/ac-library-rs/pull/3#issuecomment-688622868_

qryxip

Decide and document a guideline for choosing implementation details

2

There are two very different way of choosing how to port the original C++ library; - Convert the original program into a Rust-friendly way, and - Try to keep the...

MiSawa

Workaround for Japanese Windows environment

3

- Avoiding problems with incorrect encoding `UnicodeDecodeError: 'cp932' codec can't decode byte 0x85 in position 2897: illegal multibyte sequence` - Added option to output directly to file PowerShell converts encoding...

mizar

Fixes the CI by removing our hand-made `input!`. After all this time, I think it was not necessary.

qryxip

Fix FromIterator for Segtree

1

This pull request fixes the FromIterator implementation for the Segtree struct. The previous implementation use Iterator::size_hint().0 to get length of the iterator. However, that is incorrect.

mousecrusher2

mul_mod for 2^31 < m < 2^32

2

`mul_mod` seems easily be adapted to the case 2^31 < m < 2^32 by simply improving the last subtraction borrow check. (current code: ac-library) https://github.com/atcoder/ac-library/blob/6c88a70c8f95fef575af354900d107fbd0db1a12/atcoder/internal_math.hpp#L22-L62 (current code: ac-library-rs) https://github.com/rust-lang-ja/ac-library-rs/blob/b473a615a7d7cfe4d8b26e369808cb2aa2d2f5a0/src/internal_math.rs#L19-L84 -...

mizar

u32 modulo fix

7

https://github.com/rust-lang-ja/ac-library-rs/issues/111 Fix a problem with cases like 2^31 < modulo < 2^32 due to poor implementation of ac-library's overflow/underflow check.

mizar

Relax the constraints of `floor_sum` (revised)

1

I'm taking over the PR #99 by @nebocco . Fixes #91.

TonalidadeHidrica

Currently, `.github/workflows/test-expand.sh` runs `rustc` that creates a binary named `test` in the current working directory. This is a bit troublesome when testing locally because it creates an untracked binary file...

TonalidadeHidrica

Make `Zero` and `One` extensional traits

4

Makes `Zero` and `One` extensional traits for `Sum` and `Product`, respectively. As I said in rust-jp.slack.com 3 years ago IIRC, we might as well regard the "zero value" and "one...

qryxip