ac-library-rs icon indicating copy to clipboard operation
ac-library-rs copied to clipboard

Rename the package name

Open qryxip opened this issue 5 years ago • 2 comments

In Rust, it is common to set a repository name to foo-rs and to set a package.name to foo.

In actual, cargo new strip the "-rs" suffixes until recently.

$ cargo +1.15.1 new foo-rs --lib
note: package will be named `foo`; use --name to override
     Created library `foo-rs` project

Why don't we rename the package name to ac-library or ac_library?

qryxip avatar Sep 14 '20 09:09 qryxip

Or, or rather and, We can rename the lib.name to "atcoder" or something.

[lib]
name = "atcoder"

Then we can write in this way in examples and integration-tests (if we will write them) .

use atcoder::Dsu;

qryxip avatar Sep 14 '20 09:09 qryxip

Agreed on ac_library. I'm afraid that atcoder may give a wrong impression that this crate is officially maintained by AtCoder, which is not quite right.

koba-e964 avatar Mar 05 '22 12:03 koba-e964

I agree with this suggestion. Do you think we shuold/can change this until 2023/04/07 (deadline of the language update?)

TonalidadeHidrica avatar Mar 26 '23 20:03 TonalidadeHidrica

I think we should do. Or rather, this is the last chance.

qryxip avatar Mar 29 '23 15:03 qryxip

I came up with another name. acl.

use acl::FenwickTree;

Repository name: ac-library-rs package.name: ac-library-rs lib.name (a.k.a. "crate_name"): ac_library_rsacl

qryxip avatar Mar 29 '23 16:03 qryxip

Which name is used in crates.io ? package.name or lib.name? Also I'm not so much in favor of such a short name because it is not very descriptive.

TonalidadeHidrica avatar Mar 29 '23 16:03 TonalidadeHidrica

package.name.

Example: The default crate_name of xml-rs is xml.

qryxip avatar Mar 29 '23 16:03 qryxip

@manta1130 @kenkoooo @tttanikawa @hotman78 Mentioning to you as contributors. Would you give us your thoughts?

We have the following choices.

  1. As is

    package.name: ac-library-rs lib.name: ac_library_rs

  2. ac-library/ac_library

    package.name: ac-library lib.name: ac_library

  3. ac-library-rs/ac_library

    package.name: ac-library-rs lib.name: ac_library

  4. atcoder (same as the original ACL)

    package.name: ac-library-rs lib.name: atcoder

  5. acl

    package.name: ac-library-rs lib.name: acl

qryxip avatar Mar 29 '23 16:03 qryxip

I created two PRs for 5. and 3.

@mizar Could you choose one and merge it? As I mentioned, today is the last chance.

qryxip avatar Apr 09 '23 05:04 qryxip