wg icon indicating copy to clipboard operation
wg copied to clipboard

Actions-rs is deprecated

Open nastevens opened this issue 1 year ago • 7 comments

Per https://github.com/actions-rs the actions-rs project is deprecated and unmaintained. The associated actions have started to raise numerous warnings and are likely to stop working entirely at some point. An unscientific survey of other Rust projects seems to indicate a migration to https://github.com/dtolnay/rust-toolchain, but I would like to get some consensus from the team before charging ahead with this. This may also be an opportunity to close out #671.

I'm opening this issue here since it affects at least 20 R-E repos across multiple subteams at the time of writing: https://github.com/search?q=org%3Arust-embedded+actions-rs&type=code.

nastevens avatar May 07 '24 02:05 nastevens

There is also actions-rust-lang/setup-rust-toolchain but I don't know how the two compare.

Rahix avatar May 07 '24 18:05 Rahix

It was also pointed out to me that rustup can be used directly, it's included in the ubuntu runner images.

newAM avatar May 08 '24 00:05 newAM

I prefer to just use rustup.

jonathanpallant avatar May 08 '24 10:05 jonathanpallant

Does anyone have repos they can point to as reference of good design using GHA? Bonus points if the repo is already testing a matrix of architectures and features.

nastevens avatar May 08 '24 14:05 nastevens

svd2rust has a pretty good setup: https://github.com/rust-embedded/svd2rust/blob/6979dc40c2d812b6f4f0b4fc7a18c29233faaf85/.github/workflows/ci.yml#L50

Emilgardis avatar May 08 '24 15:05 Emilgardis

In riscv we use rust-toolchain with different targets, features, etc.

So far, it works pretty fine.

romancardenas avatar May 09 '24 14:05 romancardenas

I updated several repos to dtolnay/rust-toolchain a while ago, eg.:

  • https://github.com/rust-embedded/embedded-hal/pull/439
  • https://github.com/rp-rs/rp-hal/pull/532

Not saying that this is the best approach, only noting that it seems to work well.

jannic avatar May 14 '24 19:05 jannic