rust-i2cdev icon indicating copy to clipboard operation
rust-i2cdev copied to clipboard

Fulfillment of the I2c trait contract

Open ohunter opened this issue 1 year ago • 2 comments

This seeks to address the issue with the LinuxI2CDevice not correctly implementing the I2c trait as mentioned in rust-embedded/linux-embedded-hal#82. I am not sure whether the fix really belongs in this repo but since i2c_msg.flags isn't pub then it doesn't seem like there is another way. Setting the flag when the device doesn't implement the feature seems to have no effect which might lead to some confusion.

ohunter avatar May 03 '24 08:05 ohunter

Looks good now! Thanks for your efforts!

nastevens avatar May 07 '24 13:05 nastevens

Sorry, now rustfmt is unhappy :face_exhaling:

nastevens avatar May 07 '24 14:05 nastevens

Thanks again @ohunter, sorry it took a few tries to get things merged!

nastevens avatar May 08 '24 14:05 nastevens

No worries. I'm just happy to contribute 😀

ohunter avatar May 08 '24 14:05 ohunter