embedded-hal icon indicating copy to clipboard operation
embedded-hal copied to clipboard

Add CapturePin trait

Open YuhanLiin opened this issue 5 years ago • 4 comments
trafficstars

The CapturePin trait is the input capture analogue to the PwmPin trait, representing a single capture channel. Unlike PwmPin, there's no enable or disable methods, because some chips, such as the MSP430FR2355, may have trouble implementing those two methods on capture abstractions. The proposed trait has been implemented in msp430fr2x5x-hal.

YuhanLiin avatar Jan 04 '20 06:01 YuhanLiin

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive avatar Jan 04 '20 06:01 rust-highfive

The proposal for the trait is here, which I added after reading that I need to complete a proposal before opening a PR to add a new trait.

YuhanLiin avatar Jan 06 '20 16:01 YuhanLiin

Any updates on this?

YuhanLiin avatar Oct 26 '22 04:10 YuhanLiin

I would say let's reevaluate this after the 1.0 release.

eldruin avatar Nov 11 '22 11:11 eldruin