embedded-hal
embedded-hal copied to clipboard
Add CapturePin trait
The CapturePin trait is the input capture analogue to the PwmPin trait, representing a single capture channel. Unlike PwmPin, there's no enable or disable methods, because some chips, such as the MSP430FR2355, may have trouble implementing those two methods on capture abstractions. The proposed trait has been implemented in msp430fr2x5x-hal.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
The proposal for the trait is here, which I added after reading that I need to complete a proposal before opening a PR to add a new trait.
Any updates on this?
I would say let's reevaluate this after the 1.0 release.