cortex-m icon indicating copy to clipboard operation
cortex-m copied to clipboard

Prepare for cortex-m-rt 0.7.5

Open adamgreig opened this issue 1 year ago • 6 comments

Fixes #532.

adamgreig avatar May 19 '24 23:05 adamgreig

Before we do the releases, have we checked that the new macro works as expected and rejects mismatched hard fault signatures?

thejpster avatar May 20 '24 06:05 thejpster

Before we do the releases, have we checked that the new macro works as expected and rejects mismatched hard fault signatures?

Tests were added: https://github.com/rust-embedded/cortex-m/blob/master/cortex-m-rt/tests/compile-fail/hard-fault-bad-signature-3.rs There are more too.

It doesn't pick up on unreleased macro crate releases because it defines the dependency with a path: https://github.com/rust-embedded/cortex-m/blob/4395baee03d57a4e1763c427073da5f33ec3b17e/cortex-m-rt/Cargo.toml#L21-L22 This is probably the correct way in this crate, but yeah it does make it easy to forget to release any new version of it.

diondokter avatar May 21 '24 09:05 diondokter

I think one solution for this is for the main branch to be changed to have the version number N + 1 right after version N is released, and for any dependencies within the same repo to also use N + 1 as a version number.

jonathanpallant avatar May 21 '24 12:05 jonathanpallant

CC #535 - @jannic thinks it is important before we release

jamesmunns avatar May 21 '24 14:05 jamesmunns

Also noting that @newAM successfully yanked v0.7.4 - we should probably note this in the release docs that we are fixing those regression(s).

jamesmunns avatar May 21 '24 14:05 jamesmunns

I rebased this branch to fix CI and resolve conflicts.

newAM avatar Jun 30 '24 23:06 newAM

I've rebased and updated the changelog with the various changes. Should be ready to go now.

adamgreig avatar Nov 03 '24 18:11 adamgreig