usb-device icon indicating copy to clipboard operation
usb-device copied to clipboard

Published 20 hours ago • verified publisher icon rust-embedded-community

Turn repository into workspace and separate the tests

Open eldruin opened this issue 3 years ago • 8 comments

Reading through #100 and #101, here is a PR turning this repository into a workspace. The idea would be that if @ianrrees and @Disasm agree, we could incorporate their device-side testing suite implementations into this repository so that everything is in a single place. The directory structure would be:

|- usb-device                      // main crate
|- tests                           // test suite
    |- test_class_host             // host-side program
    |- <stm32xxxx>_device_tests    // device-side impl for some stm32 devices
    |- <atsamdxxxxx>_device_tests  // device-side impl for some atsamd devices

For now I just linked the repositories in the readme like in #101. This includes the text from #101 as well. I hope that is fine with @ianrrees. I do not care about the names of the device test folders. Feel free to propose a new one. Thoughts?

cc: @ryan-summers

eldruin avatar Aug 09 '22 07:08 eldruin

Opinions @ianrrees and @Disasm?

eldruin avatar Aug 09 '22 08:08 eldruin

This includes the text from https://github.com/rust-embedded-community/usb-device/pull/101 as well. I hope that is fine with @ianrrees.

Yep, totally fine!

I'll aim to put some more thoughts in #100 later today.

ianrrees avatar Aug 09 '22 23:08 ianrrees

Just a thought: what if we set up the host side test program as a normal bin? I think that could allow a HAL developer to do something like cargo install usb-device to get the host-side test suite.

ianrrees avatar Aug 11 '22 01:08 ianrrees

This looks like a better solution compared to what we have now, thank you!

Disasm avatar Aug 14 '22 16:08 Disasm

This is over a year old, what happened?

Finomnis avatar Sep 11 '23 12:09 Finomnis

I believe the desire was lost and it now has a bunch of conflicts. usb-device isn't super well maintained - I review PRs in my spare time, but don't have time to do any active development on it.

ryan-summers avatar Sep 11 '23 12:09 ryan-summers

Exactly, @ryan-summers - Rust USB device stuff has been on my "next month or two" list for about two years now... What we have is a good start, but it could definitely use some focused attention.

ianrrees avatar Sep 12 '23 09:09 ianrrees

Rust USB device stuff has been on my "next month or two" list for about two years now...

Understandable, though. I'll also revert back to "good enough" once my usecase is fulfilled. :/

Finomnis avatar Sep 12 '23 11:09 Finomnis