Make `Migration::applied` public

Open Protryon opened this issue 3 years ago • 2 comments

In order to implement AsyncMigrate for a custom SQL target, this function is needed to construct Migration types. This is specifically required by the AsyncQuery::query function.

At the moment, this API is pub(crate), requiring an unsafe transmute to construct any Migration type outside of refinery-core crate.

See example in klickhouse crate: https://github.com/Protryon/klickhouse/blob/master/klickhouse/src/migrate.rs#L58

Sep 27 '22 02:09 Protryon

Hi, and thanks for your interest! Wouldn't you prefer to have refinery support Clickhouse directly?

Sep 29 '22 13:09 jxs

@jxs Sure, it was simply more expedient for my immediate needs to implement it outside. It's also a bit hacky IMO. I can open a PR here to add support.

Oct 17 '22 17:10 Protryon