cargo-xwin icon indicating copy to clipboard operation
cargo-xwin copied to clipboard

Show messages on non-interactive download

Open konstin opened this issue 1 year ago • 8 comments
trafficstars

Since today, our previously working workflows timeout without any output: https://github.com/astral-sh/uv/actions/runs/11329544632/job/31505329690?pr=8176

Locally, the exact command continues to work, even if I set a new cache dir.

I tried adding -vvv (no additional output) and removing the cache, both without effect.

konstin avatar Oct 14 '24 14:10 konstin

Seems like it was just canceled because the mkdocs workflow failed?

Error: The operation was canceled.

also it was timed-out:

The job running on runner GitHub Actions 4 has exceeded the maximum execution time of 10 minutes.

messense avatar Oct 14 '24 14:10 messense

It fails even with mkdocs fixed, both cargo xwin time out after having no output for a while: https://github.com/astral-sh/uv/actions/runs/11329897380/job/31506488205

konstin avatar Oct 14 '24 15:10 konstin

It's seem to be related to ubuntu-latest upgrading from 22.04 to 24.04; surprisingly, it passes for me locally on 24.04

konstin avatar Oct 14 '24 16:10 konstin

Downgrading to 22.04 doesn't seem to fix; I assume there was some change in GitHub Actions but i fail to pinpoint it.

konstin avatar Oct 14 '24 16:10 konstin

Could it be the Windows SDK download timing out? If it's not cached, it can take about 10+ minutes on Github Actions. It could've our GHA cached version expired, as such we might need to temporarily increase the job to 20+ minutes.

samypr100 avatar Oct 14 '24 18:10 samypr100

That's an interesting idea. Probably worth a try!

zanieb avatar Oct 14 '24 18:10 zanieb

@zanieb See https://github.com/astral-sh/uv/pull/3600#issuecomment-2112539609 (first time we used xwin windows sdk took 12 minutes) - it's just been always cached ever since and somehow the cache busted and the timeout-minutes setting never let it recover

samypr100 avatar Oct 14 '24 18:10 samypr100

Thanks @samypr100 for identifying the problem!

I've changed this to a feature request: Please show message when non-interactive download is happening.

konstin avatar Oct 14 '24 20:10 konstin

Added in 29c68706bf02b82b9858970cc4dbb557645dfc8e

messense avatar Dec 21 '24 10:12 messense