ssimulacra2_bin icon indicating copy to clipboard operation
ssimulacra2_bin copied to clipboard

Published 20 hours ago • verified publisher icon rust-av

add jxl support

Open Quackdoc opened this issue 1 year ago • 3 comments

jxl-oxide now has image interop, we can support it like so

Quackdoc avatar Nov 21 '24 23:11 Quackdoc

Fix clippy errors please, and make jxl a feature. Might have to look at why this adds so much bloat before merging..

FreezyLemon avatar Dec 06 '24 20:12 FreezyLemon

Fix clippy errors please, and make jxl a feature. Might have to look at why this adds so much bloat before merging..

I need some time to figure out how I want to make it optional, this will be important for adding other formats in the future as image-rs has a policy of not taking some formats in (IE. heif will be an issue), converting to a draft until I find the time to figure this out, which has been in very short supply lately...

EDIT: may also just wait for https://github.com/image-rs/image/pull/2372 to blow over and utilize whatever this may look like

Quackdoc avatar Dec 07 '24 13:12 Quackdoc

Sure, take your time. Just added another comment because I wasn't sure that I was clear enough in my review.

FreezyLemon avatar Dec 07 '24 15:12 FreezyLemon