terraform-provider-rundeck icon indicating copy to clipboard operation
terraform-provider-rundeck copied to clipboard

Adding option url parameters

Open b0tting opened this issue 1 year ago • 1 comments

This is a PR to add the new parameters for URL based options (basic auth, regex, bearer token etcetera) and solve #144. I suggest using a second level block to group these parameters and prevent clutter in the docs and code. There is no additional validation, ie. you could select basic authentication and add a bearer token at the moment.

@fdevans This code is not working at this time. I think the issue is in jobFromResourceData(:846) with the JobValueChoicesURL object not being a map of strings. My knowledge of Go is very limited and I could not find another component with a similar setup. I hope my groundwork is enough to finish this with little extra effort. If not, feel free to delete this pull request.

b0tting avatar Nov 04 '24 16:11 b0tting

Thanks for the headstart. Hopefully some other members of the community can help improve on the work you've started here. I'll likely do another round of reviews and merges in a few weeks.

fdevans avatar Nov 04 '24 17:11 fdevans

This has been open for a while without traction. Since PR #203 significantly changes the provider I'm going to close this and we can revisit in the new 1.0.0 version after it's fully released.

fdevans avatar Nov 17 '25 17:11 fdevans