rules_proto_grpc icon indicating copy to clipboard operation
rules_proto_grpc copied to clipboard

Honor prefix_path when output_mode is NO_PREFIX_FLAT

Open linzhp opened this issue 1 year ago • 1 comments

Currently prefix_path is honored when output mode is PREFIXED or NO_PREFIX, but not honored when it's NO_PREFIX_FLAT. This is inconsistent. This PR fixed that.

Furthermore, this PR is one way of fixing #309, because people will be able to set something below to get rid of the "k8s.io" path generated by grpc:

python_grpc_library(
    name = "py_lib",
    protos = [":proto_lib"],
    output_mode = "NO_PREFIX_FLAT",
    prefix_path = "k8s/io/apimachinary",
    python_version = "PY3",
)

linzhp avatar Jan 17 '24 23:01 linzhp

@aaliddell is the CI broken?

linzhp avatar Jan 19 '24 15:01 linzhp