rules_proto_grpc icon indicating copy to clipboard operation
rules_proto_grpc copied to clipboard

Published 20 hours ago • verified publisher icon rules-proto-grpc

JS rules don't work with latest protobuf (3.21.x) repo

Open srabraham opened this issue 3 years ago • 1 comments

Description

For some unknown reason, Google removed JavaScript support from the core protocolbuffers repo: https://github.com/protocolbuffers/protobuf/pull/9874

This makes rules_proto_grpc unable to generate JavaScript protos. The correct new way to do things is to bring in https://github.com/protocolbuffers/protobuf-javascript and use it as a plugin to protoc.

The error I get currently with a rules_proto_grpc JS target is: "protoc-gen-js: program not found or is not executable"

Thanks for your work on this, Adam!

@alexeagle FYI

srabraham avatar Aug 11 '22 19:08 srabraham

Relevant: https://github.com/protocolbuffers/protobuf-javascript/issues/127#issuecomment-1204202870

srabraham avatar Aug 11 '22 20:08 srabraham

Thanks for the pointers on this, this is adopted in #178

aaliddell avatar Aug 23 '22 21:08 aaliddell

Awesome, thanks!

srabraham avatar Aug 23 '22 21:08 srabraham