Issues on https://new.weedtowonder.org/domestication.html

[danielhjacobs]

Describe the bug

Last edited December 1, 2023:

I will mainly list issues that do not also apply to #10173. Though it's worth noting issue 1 from there also applies here:

1. When clicking the number 3 on the left side, which contains an animation loaded with mixed AVM, if you navigate away from that page and then back, the animation becomes duplicated. That may relate to Loader.unloadAndStop.
2. When clicking the number 3 on the left side, the page slows down as the following error prints to the console repeatedly, both before the mixed AVM PR and after it:

ERROR core/src/avm2/events.rs:424 Error dispatching event EventObject(EventObject { type: "frameConstructed", class: flash.events::Event, ptr: 0x2bacae8 }) to handler FunctionObject(FunctionObject { ptr: 0x381de10 }) : TypeError: Error #1009: Cannot access a property or method of a null object reference. (accessing field: length)
	at flashx.textLayout.elements::ParagraphElement/getText()
	at flashx.textLayout.container::TextContainerManager/getText()
	at fl.text::SingleTextContainerManager/get textLength()
	at fl.text::TLFTextField/setSelection()
	at fl.text::TLFTextField/doTypeSet()
	at fl.text::TLFTextField/set selectable()
	at fl.text::RuntimeManager/configureInstance()
	at fl.text::RuntimeManager/getInstanceForInfo()
	at fl.timeline::TimelineManager/getInstanceForInfoWithXns()
	at fl.timeline::TimelineManager/getInstance()
	at fl.motion::AnimatorBase/play()
	at fl.motion::AnimatorBase$/processCurrentFrame()
	at fl.motion::AnimatorBase/handleEnterFrame()

Expected behavior

1. The animation is not supposed to layer on top of itself, as it's meant to fully unload when navigating to a different page.
2. No errors should occur when clicking that page.

Affected platform

Browser's extension

Operating system

Fedora Linux 38

Browser

Mozilla Firefox 119

Additional information

This is an AVM2 Flex animation. See also #8006 and #10173.

[Lord-McSweeney]

Issue 2.3 (iii) has been stubbed.

[Lord-McSweeney]

The getFirstLeaf error was improved by #13214 and #13179.

[danielhjacobs]

The getFirstLeaf error appears to have at some point been fixed. The first video is now loading like all the others, though it is taking an abnormally long amount of time to first load.

That means the only unique errors left from this issue that don't also affect #10173 are mixed AVM and another TLF error. As noted, the mixed AVM PR fixed the original first error in testing, but the animations become layered as they never unload.