Rudrakh Panigrahi

Results 27 comments of Rudrakh Panigrahi

@alyssawilk any comments on this disparity? Seems to similar to an issue I am facing #37140. Thanks!

@alyssawilk Thanks for the response! It definitely makes sense based on what `use_remote_address` is set to, but if you check out the example configurations in #37140 we are forced to...

We could decrement the number of hops to maintain backward compatibility. From the docs looks like the following configurations should behave the same as `useRemoteAddress` is used by HCM only...

@ryanhristovski just a quick follow up - is this still being worked on?

> @rudrakhp please squash your commits and we can get this in. Also have you tested this end-to-end? I added a case for invalid URL in the e2e test suite,...

> @rudrakhp did you get a chance to look into the test failures. This would be a good one to get in. @ashutosh-narkar was out on vacation, will get something...

@ashutosh-narkar looks like the place where I was adding the test was for testing istio setup with the plugin enabled but requests were not going via OPA. I don't see...

Sounds good to me! We should probably skip running e2e tests as well if there are only site or api changes (without changes in implementation).

@arkodg interested in picking up this issue, thanks!