gemstash icon indicating copy to clipboard operation
gemstash copied to clipboard

Fix failing spec on ruby 3.3

Open segiddins opened this issue 1 year ago • 4 comments
trafficstars

Signed-off-by: Samuel Giddins [email protected]

Description:


Tasks:

  • Describe the problem / feature
  • Write tests

I will abide by the code of conduct.

segiddins avatar Nov 19 '24 21:11 segiddins

Weirdly, this change made jruby test fail, hm. Were they also failing without this? (Not 13h ago. Hm.)

olleolleolle avatar Nov 20 '24 09:11 olleolleolle

Gem::GemNotFoundException: can't find gem gem_server_conformance (>= 0) with executable gem_server_conformance

segiddins avatar Nov 20 '24 16:11 segiddins

3.3 failed now, on: The presence of the ruby platform in the version parentheses. JRuby passed, though.

       expect(execute("gem", ["search", "-ar", "speaker"], env: env)).
         to exit_success.and_output(/speaker \(0.1.0\)/)

       expected 'gem search -ar speaker' in '/home/runner/work/gemstash/gemstash' to output:
       (?-mix:speaker \(0.1.0\))

       but instead it output:
       speaker (0.1.0 ruby)

olleolleolle avatar Nov 21 '24 07:11 olleolleolle

I merged #407 with a fix that passed CI and locally. Please let me know if it causes any issues.

martinemde avatar Apr 13 '25 04:04 martinemde

The test suite currently passes, so I will boldly close this PR - thanks, everyone! ❤️

olleolleolle avatar Aug 16 '25 07:08 olleolleolle